Skip to content

refactor: centralize daemon command registry#693

Merged
thymikee merged 1 commit into
mainfrom
codex/daemon-command-registry
Jun 5, 2026
Merged

refactor: centralize daemon command registry#693
thymikee merged 1 commit into
mainfrom
codex/daemon-command-registry

Conversation

@thymikee
Copy link
Copy Markdown
Member

@thymikee thymikee commented Jun 5, 2026

Summary

Centralize daemon route ownership and request-policy traits in a new internal daemon command registry, with an ADR documenting the contract.

Simplifies handler/router data flow by removing duplicated handler coverage tables, slimming request routing, and adding focused registry plus provider-policy coverage.

Validation

Passed pnpm check:quick, focused daemon registry/router/scope unit tests, focused provider policy integration, broader provider integration, progress integration checks, pnpm build, targeted formatting, and git diff --check.

Known gap: full pnpm check:unit hit sandbox-sensitive listener/child-process failures unrelated to the touched focused daemon tests.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 5, 2026

Size Report

Metric Base Current Diff
JS raw 1.1 MB 1.1 MB -2.1 kB
JS gzip 370.7 kB 370.0 kB -768 B
npm tarball 477.2 kB 476.3 kB -900 B
npm unpacked 1.6 MB 1.6 MB -2.1 kB

Startup median (7 runs, lower is better):

Scenario Base Current Diff
CLI --version 27.0 ms 28.0 ms +1.0 ms
CLI --help 42.9 ms 43.1 ms +0.2 ms

Top changed chunks:

Chunk Raw diff Gzip diff
dist/src/2415.js +874 B +283 B
dist/src/session.js -486 B -140 B
dist/src/args.js -325 B -113 B
dist/src/snapshot.js -189 B -89 B
dist/src/record-trace.js -119 B -65 B

@thymikee thymikee force-pushed the codex/daemon-command-registry branch 2 times, most recently from 92915b2 to 54b3107 Compare June 5, 2026 16:18
@thymikee thymikee force-pushed the codex/daemon-command-registry branch from 54b3107 to 5c862b6 Compare June 5, 2026 16:19
@thymikee thymikee merged commit f2424f9 into main Jun 5, 2026
18 checks passed
@thymikee thymikee deleted the codex/daemon-command-registry branch June 5, 2026 16:34
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 5, 2026

PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-06-05 16:34 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant